Thomas Debesse
e74e82ea77
This does the exact opposite of06e96074from !16129. Before LLVM commit 702d5de4 opaque pointers were supported but not enabled by default when building LLVM. They were made default in commit 702d5de4. LLVM commit d69e9f9d introduced -opaque-pointers/-no-opaque-pointers cc1 options to enable or disable them whatever the LLVM default is. Those two commits follow llvmorg-15-init and precede llvmorg-15.0.0-rc1 tags. Since LLVM commit d785a8ea, the CLANG_ENABLE_OPAQUE_POINTERS build option of LLVM is removed, meaning there is no way to build LLVM with opaque pointers enabled by default. It was said at the time it was still possible to explicitly disable opaque pointers via cc1 -no-opaque-pointers option, but it is known a later commit broke backward compatibility provided by -no-opaque-pointers as verified with arbitrary commit d7d586e5, so there is no way to use opaque pointers starting with LLVM 16. Those two commits follow llvmorg-16-init and precede llvmorg-16.0.0-rc1 tags. Since Mesa commit977dbfc9opaque pointers are properly implemented in Clover and used. If we don't pass -opaque-pointers to Clang on LLVM versions supporting opaque pointers but disabling them by default, there will be an API mismatch between Mesa and LLVM and Clover will not work. Signed-off-by: Thomas Debesse <dev@illwieckz.net> Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19290>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.