Jason Ekstrand
e265583ee1
The original intention was to put all the non-dynamic UBOs first followed by all the dynamic ones. However, we got the calculations wrong and, once you went above one descriptor set, things start stomping each other. Also, the whole strategy is a bit busted. Vulkan pipeline layout compatability rules say that it's ok to create a pipeline with one layout and then bind with another so long as the bottom N descriptor set layouts match and the pipeline uses at most N descriptors. This means that, while it's safe to have each subsequent set add onto a given pool of descriptors, if you're going to combine two of those pools, you need to be careful that the position of descriptors in set N only depends on the layouts of sets M <= N. The easy way to do this is to interleve where we do the UBOs for set 0 then dynamic for set 0 then UBOs for set 1 then dynamic for set 1, etc. Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16276>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.