Karol Herbst
dad5ee1039
The compiler won't be able to emit pack_64_4x16, so we should prevent
nir_opt_algebraic to optimize to it. This fixes an infinite optimization
loop inside brw_nir_optimize:
nir_copy_prop
16x4 %77 = @load_global (%80)
32 %61995 = pack_32_2x16_split %77.x, %77.y
32 %61998 = pack_32_2x16_split %77.z, %77.w
64 %61999 = pack_64_2x32_split %61995, %61998
64 %76 = iadd %100, %79
@store_global (%61999, %76)
nir_opt_algebraic
16x4 %77 = @load_global (%80)
32 %61995 = pack_32_2x16_split %77.x, %77.y
32 %61998 = pack_32_2x16_split %77.z, %77.w
16x4 %62000 = vec4 %77.x, %77.y, %77.z, %77.w
64 %62001 = pack_64_4x16 %62000
64 %76 = iadd %100, %79
@store_global (%62001, %76)
nir_lower_pack
16x4 %77 = @load_global (%80)
16x4 %62000 = vec4 %77.x, %77.y, %77.z, %77.w
16 %62002 = mov %62000.y
16 %62003 = mov %62000.x
32 %62004 = pack_32_2x16_split %62003, %62002
16 %62005 = mov %62000.w
16 %62006 = mov %62000.z
32 %62007 = pack_32_2x16_split %62006, %62005
64 %62008 = pack_64_2x32_split %62004, %62007
64 %76 = iadd %100, %79
@store_global (%62008, %76)
// brw_nir_optimize loops here
nir_copy_prop
16x4 %77 = @load_global (%80)
32 %62004 = pack_32_2x16_split %77.x, %77.y
32 %62007 = pack_32_2x16_split %77.z, %77.w
64 %62008 = pack_64_2x32_split %62004, %62007
64 %76 = iadd %100, %79
@store_global (%62008, %76)
llvmpipe has a similar issue inside lp_build_opt_nir
Fixes: b1bc691b0f ("nir/algebraic: add and improve pack/unpack patterns")
Acked-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33347>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.