Boris Brezillon
dad53edc9c
Commitf64a7c1506("pan/layout: Check the wsi_layout consistency in wsi_row_pitch_to_row_stride()") introduced stricter alignments on pre-v7 for linear/tiled imports. It turns out alignment constraints on pre-v7 are weaker than they are on v7+, and this got lost in the refactoring. Let's fix linear_or_tiled_row_align_req() helper so we can import images that don't have their base address/row_pitch aligned on a cacheline, and only cacheline alignment for images we create ourselves. Also add unittests to make sure we don't regress that in the future. With this being tested, we can also use pan_linear_or_tiled_row_align_req() in offset_align_for_mod() (test-layout.cpp) instead of open-coding it. Fixes:f64a7c1506("pan/layout: Check the wsi_layout consistency in wsi_row_pitch_to_row_stride()") Fixes:916f75a2a6("pan/layout: Test WSI import behavior on all supported format/mods") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com> Reviewed-by: Eric R. Smith <eric.smith@collabora.com> Tested-by: Eric R. Smith <eric.smith@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35555>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.