Iago Toral Quiroga
daa865fb2c
If a CPU job comes first in a command buffer with a semaphore wait operation we need to wait on the CPU for the semaphore to be signaled before we process the job. We have been doing this with a WaitForIdle operation, but that only works if the semaphore has been submitted for signaling from the same instance of the driver. If we have an imported payload from another instance in our semaphore however, waitForIdle may return too early since the submission to signal the semaphore may have been submitted by a different instance of the driver as well, and our wait for idle checks only know about this instance submissions. To fix this, we always submit a noop job from our instance that waits on the semaphores on the GPU and follow up with WaitForIdle to wait for that to complete. Fixes test failures and/or assert crashes in: dEQP-VK.synchronization.cross_instance.* (when enabling support for semaphore imports) Reviewed-by: Melissa Wen <mwen@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15342>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.