d6fd8b4201
Just compare against the size that was declared. This is probably overkill. I couldn't figure out what vulkan says wrt OOB access of shared memory. D3D however (which is very strict about these things) says that for TGSM writes the entire contents of the TGSM becomes undefined, for reads the result is undefined. Hence, rather than masking out such accesses, to avoid the segfaults it would be enough to just clamp the offsets to valid values. nir doesn't seem easily able to tell us if an access is guaranteed in-bound (unlike for ssbo access), so assume always potentially OOB. v2: fix rusticl - for cl we don't know the shared size at compilation time, this is only provided at launch_grid() time, the nir shader info shared_size might be zero. Hence pass through the size via cs jit context, there already actually was a member in there which looks like it was intended for that (interestingly enough, the cs jit context was actually unused, since resources are passed elsewhere nowadays). Reviewed-by: Brian Paul <brian.paul@broadcom.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38307>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.