Erik Faye-Lund
d37aa08f61
The OpenGL 4.6 specification, section 14.5.2.1 (Line Stipple) says: > The masking is achieved using three parameters: the 16-bit line > stipple p, the line repeat count r, and an integer stipple counter s. This is pretty clear that the stipple counter shouldn't carry fractional parts. But we also don't really do anything useful with the fractional part anyway, apart from skewing the third or later line-segments Properly carrying over the fractional parts as the Vulkan specification allows for rectangular lines is trickier than this and would require us to use a shorter output-line at the start of the following line-segments. But let's just do what the OpenGL specification describes, and the Vulkan specification allows for now. This, combined with the following patch for the vulkan CTS makes the last two rasterization-tests pass for me: https://github.com/KhronosGroup/VK-GL-CTS/pull/279 Fixes the "spec/!opengl 1.1/linestipple/line strip" piglit-test. Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12327>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.