cdffa3e114
Commite99e7aa4began passing start > 0 to indexed draw calls rather than keeping start at 0 and manually advancing ib->ptr. This should work fine, however, there have been instances of software fallbacks not handling things right. vbo_sw_primitive_restart had a bug where it was ignoring "start" and always calling find_sub_primitives with start = 0 and end = ib->count. This meant that when start > 0, it was analyzing the wrong part of the index buffer when finding subprimitives. In theory, each _mesa_prim can have a different "start" value. But the code only calls find_sub_primitives once, because it wants to map, analyze, and unmap the index buffer before calling ctx->Draw, as some drivers don't support drawing with the index buffer mapped. To handle this, we break vbo_sw_primitive_restart calls into sections where "start" matches across all the primitives, similar to how I handled the issue in tnl in commitbd6120f562. In the common case, start matches and we handle it in one pass anyway. Fixes Piglit's primitive-restart VBO_COMBINED_VERTEX_AND_INDEX test and KHR-GL33.pipeline_statistics_query_tests_ARB.functional_primitives_vertices_submitted_and_clipping_input_output_primitives on Intel Ivybridge and older (which don't do arbitrary cut indices). Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4052 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9417>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.