Alyssa Rosenzweig
cbd9cb04cf
base vertex is GL, first vertex is VK. because we missed this check, VK (but not GL) shaders using first vertex (but not base instance) would not get that flag set and so hk wouldn't bother uploading the draw parameters, so first_vertex would read garbage. because vertex ID is defined differently between the Khronos and Microsoft APIs, every complex DXVK vertex shader will implement vertex ID with a subtraction of first vertex. forcing geometry shaders worked around the bug, because IIRC geometry shaders also force the draw parameter upload path for $REASONS. maybe disabling preambles changed symptoms simply because the uniform file looked different, and we were reading uninitialized garbage regardless writing stuff in preambles would maybe change the garbage for other draws or something. (Not sure on the details but the physical uniform registers I guess get reused over the lifetime of a shader core and never zero initialized) So we were reading uninitialized garbage and yeah everything blows up Anyway. I just wasted too much of my life on this. This single line of code fixes rendering in every DX11 game. that's probably not an exaggeration. Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31532>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.