ca9e0871fb
The GL driver was getting loop unrolling from the GLSL compiler frontend, but NIR unrolling is more sophisticated, so prefer that. The only caveat is that loop unrolling is implemented in the Mesa state tracker, so our backend won't have a chance to undo the optimization if it causes us to lower thread count or spill, so we choose to be a bit more conservative with the configuration than what we were doing with GLSL. Shader-db results follow. Increase in instruction counts is expected due to additional unrolling. We lose threads in very few shaders, but we make up for this with the additional unrolling and reduced spilling. We also managed to get 3 more shaders to compile successfully. total instructions in shared programs: 13416427 -> 13461431 (0.34%) instructions in affected programs: 96936 -> 141940 (46.43%) helped: 58 HURT: 216 Instructions are HURT. total threads in shared programs: 410626 -> 410598 (<.01%) threads in affected programs: 56 -> 28 (-50.00%) helped: 0 HURT: 14 Threads are HURT. total loops in shared programs: 2121 -> 1708 (-19.47%) loops in affected programs: 468 -> 55 (-88.25%) helped: 446 HURT: 47 Loops are helped. total uniforms in shared programs: 3676567 -> 3691185 (0.40%) uniforms in affected programs: 25304 -> 39922 (57.77%) helped: 23 HURT: 199 Uniforms are HURT. total spills in shared programs: 5902 -> 5727 (-2.97%) spills in affected programs: 285 -> 110 (-61.40%) helped: 19 HURT: 0 total fills in shared programs: 13308 -> 13121 (-1.41%) fills in affected programs: 301 -> 114 (-62.13%) helped: 19 HURT: 0 total sfu-stalls in shared programs: 31860 -> 32856 (3.13%) sfu-stalls in affected programs: 1692 -> 2688 (58.87%) helped: 25 HURT: 196 Sfu-stalls are HURT. total inst-and-stalls in shared programs: 13448287 -> 13494287 (0.34%) inst-and-stalls in affected programs: 98404 -> 144404 (46.75%) helped: 57 HURT: 217 Inst-and-stalls are HURT. total nops in shared programs: 329276 -> 329551 (0.08%) nops in affected programs: 2189 -> 2464 (12.56%) helped: 58 HURT: 181 Nops are HURT. LOST: 0 GAINED: 3 Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10647>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.