bef37336fb
We're supposed to completely ignore VkTimelineSemaphoreSubmitInfo if there aren't any timeline semaphores, including the array lengths, which is made clear by the various VUs already cited by the code. The vkQueueSubmit() path correctly handled this when asserting but still dereferenced pWaitSemaphoreValues unconditionally, which could lead to dereferencing an invalid pointer if waitSemaphoreValueCount is less than waitSemaphoreCount. The vkQueueSparseBind() path didn't even assert correctly. Bring vkQueueSparseBind() in line with vkQueueSubmit() and make both only dereference the wait/signal array once we've determined it must be present. While we're here, also fix the assert in vkQueueSubmit() to disallow a waitSemaphoreValueCount of 0 if there are timeline semaphores present, which conversely is not allowed. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36989>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.