Alejandro Piñeiro
bcb8dd7432
This is needed due Vulkan because by spec (31.1. Limit Requirements) the minimum value for the following limits are the following ones: maxPerStageDescriptorSampledImages 16 maxPerStageDescriptorStorageImages 4 maxPerStageDescriptorInputAttachments 4 And we are using v3d textures for all of them, so current limit would not be enough for some cases. Note that as the current comment explains there is not exactly a HW limit for it, so we could bump to 32 for example, but let's just be conservative and ask the minimum required. It is worth to note that we needed to maintain the same value for the OpenGL case, as it gets a register allocation failure on some GL cases. We tried to fix that with small changes on the nir scheduler, but we found that it would require some non-trivial effort to get it done (that eventually we would need to). Fixes tests like: dEQP-VK.binding_model.descriptorset_random.sets16.constant.ubolimitlow.sbolimitlow.imglimitlow.noiub.uab.comp.noia.0 v2: keep the previous limit for Opengl (Eric) Reviewed-by: Eric Anholt <eric@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6999>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.