Faith Ekstrand
b8d50542c0
The pixld.covmask instruction returns the coverage mask for the entire pixel being shaded, not the set of samples covered by the current FS invocation as required by GL/Vulkan. In order to get the GL/Vulkan behavior, we have to mask off samples not covered by the current FS invocation. Previously, we handled this by masking by 1 << gl_SampleID. This required us to force full sample shading whenever gl_SampleMaskIn[] was used. Otherwise, we didn't know what to mask. Instead, this commit switches us to using an array in CB0 which has a sample mask for each sample, representing the set of samples in that sample's pass. Masking by this allows us to get the full range of variability provided by NVIDIA's multi-pass MSAA hardware. It also allows us to eliminate the workaround that forced per-sample shading for gl_SampleMaskIn[] because we can adjust the masks from the API side as needed. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29194>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.