Rob Hughes
b79013ead9
WSL version 1 has a known limitation that the kernel does not support the memfd_create() syscall, and it always returns -1 (see https://github.com/microsoft/WSL/issues/3542). This results in lavapipe/llvmpipe failing to create the anonymous file it needs for allocations from the pipe_screen object, which in turn results in results in failed application calls to Vulkan APIs (in the case I observed, vkMapMemory returned an invalid (0xffffffff) pointer along with VK_SUCCESS, leading to the application segfaulting). This issue can be reproduced by simply running `vkcube` (or, presumably any other simple Vulkan application) inside WSL 1, e.g.: xvfb-run -s '-screen 0 1024x768x24' vkcube --c 300 This patch addresses the issue with several changes: 1. llvmpipe_create_screen() now checks for errors from the os_create_anonymous_file function and errors out early, making it easier to track down issues similar to this. Previously, the invalid fd of -1 would be stored in the pipe_screen struct and the problems would only appear later. 2. os_create_anonymous_file() now attempts to handle the case where memfd_create() fails, by falling back to creating a file in a temporary directory. This fallback is the same as is already done for builds that don't have memfd_create available at build time - note that the difference here is that this is a _runtime_ fallback, as is needed for the case of WSL 1. 3. The fallback logic previously relied on the XDG_RUNTIME_DIR environment variable, which might not be set when running inside WSL because there is unlikely to be a desktop environment configured. This patch adds a fallback of creating a new directory inside /tmp in this case. Reviewed-by: Lucas Fryzek <lfryzek@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37679>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.