b22f682a31
The remap table adds an array lookup into 75% of CALL_* macros, which are used to call GL functions through the dispatch table. Removing the array lookup reduces overhead of dispatch table calls. Since libglapi is now required to be from the same build as libgallium, the remap table is no longer needed. This change doesn't remove the remapping table. It only disables it. Compare asm: Before: 0000000000000000 <_mesa_unmarshal_Uniform1f>: 0: f3 0f 1e fa endbr64 4: 48 83 ec 08 sub $0x8,%rsp 8: 48 8b 05 00 00 00 00 mov 0x0(%rip),%rax # f <_mesa_unmarshal_Uniform1f+0xf> f: 8b 4e 04 mov 0x4(%rsi),%ecx 12: 31 d2 xor %edx,%edx 14: f3 0f 10 46 08 movss 0x8(%rsi),%xmm0 19: 48 63 80 a8 01 00 00 movslq 0x1a8(%rax),%rax 20: 85 c0 test %eax,%eax 22: 78 08 js 2c <_mesa_unmarshal_Uniform1f+0x2c> 24: 48 8b 57 40 mov 0x40(%rdi),%rdx 28: 48 8b 14 c2 mov (%rdx,%rax,8),%rdx 2c: 89 cf mov %ecx,%edi 2e: ff d2 call *%rdx 30: b8 02 00 00 00 mov $0x2,%eax 35: 48 83 c4 08 add $0x8,%rsp 39: c3 ret After: 0000000000000000 <_mesa_unmarshal_Uniform1f>: 0: f3 0f 1e fa endbr64 4: 48 89 f8 mov %rdi,%rax 7: 48 83 ec 08 sub $0x8,%rsp b: f3 0f 10 46 08 movss 0x8(%rsi),%xmm0 10: 8b 7e 04 mov 0x4(%rsi),%edi 13: 48 8b 40 40 mov 0x40(%rax),%rax 17: ff 90 10 10 00 00 call *0x1010(%rax) 1d: b8 02 00 00 00 mov $0x2,%eax 22: 48 83 c4 08 add $0x8,%rsp 26: c3 ret Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Reviewed-by: Eric Engestrom <None> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32789>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.