Antonio Ospite
b016f218fb
When cross-building for Android meson fails to find supported compiler arguments for the C++ cross-compiler, e.g.: ``` Compiler for C++ supports arguments -Wno-array-bounds: NO (cached) Compiler for C++ supports arguments -Wno-overflow: NO Compiler for C++ supports arguments -Wno-c++11-narrowing: NO (cached) Compiler for C++ supports arguments -Wno-vla-cxx-extension: NO (cached) ``` This is due to an **unrelated** and more generic compilation failure when testing for the supported arguments, e.g.: ``` Command line: `/tmp/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android34-clang++ -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -static-libstdc++ /home/ao2/Collabora/GOO0042/mesa/_build/meson-private/tmpv6_hke9l/testfile.cpp -o /home/ao2/Collabora/GOO0042/mesa/_build/meson-private/tmpv6_hke9l/output.obj -c -Wno-error=c99-designator -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=self-assign -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Werror=implicit-function-declaration -Werror=unknown-warning-option -Werror=unused-command-line-argument -Werror=ignored-optimization-argument -Wvla-cxx-extension -Wno-vla-cxx-extension` -> 1 stderr: clang++: error: argument unused during compilation: '-static-libstdc++' [-Werror,-Wunused-command-line-argument] ----------- Compiler for C++ supports arguments -Wno-vla-cxx-extension: NO ``` The issue is caused by how the cross compiler is set up by .gitlab-ci/container/create-android-cross-file.sh Allow the cross compiler to still start even when the `-Werror,-Wunused-command-line-argument` error occurs in order to be able to actually detect other arguments: ``` Command line: `/tmp/android-ndk-r27c/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android34-clang++ -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables --start-no-unused-arguments -static-libstdc++ --end-no-unused-arguments /home/ao2/Collabora/GOO0042/mesa/_build/meson-private/tmpm6eolxed/testfile.cpp -o /home/ao2/Collabora/GOO0042/mesa/_build/meson-private/tmpm6eolxed/output.obj -c -Wno-error=c99-designator -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=self-assign -D_FILE_OFFSET_BITS=64 -O0 -fpermissive -Werror=implicit-function-declaration -Werror=unknown-warning-option -Werror=unused-command-line-argument -Werror=ignored-optimization-argument -Wvla-cxx-extension -Wno-vla-cxx-extension` -> 0 Compiler for C++ supports arguments -Wno-vla-cxx-extension: YES ``` This makes argument detection work again, e.g: ``` Compiler for C++ supports arguments -Wno-array-bounds: YES (cached) Compiler for C++ supports arguments -Wno-overflow: YES Compiler for C++ supports arguments -Wno-c++11-narrowing: YES (cached) Compiler for C++ supports arguments -Wno-vla-cxx-extension: YES (cached) ``` Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12441 Reviewed-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Valentine Burley <valentine.burley@collabora.com> Reviewed-by: Rob Clark <robclark@freedesktop.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33013>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.