Pavel Ondračka
aeae7b812c
This will prevent a regression in the number of inlined constants in a later commit. Constructs like 4.000000 (0x48).w110 works just fine. There is a small behavioral change. We would previously allow positive and negative same-value contants to be produced, e.g., 4.000000 (0x48).w-w__ and this would be later split into some extra movs in the dataflow swizzle pass. We now explicitly check that the final swizzle is valid while inlining. So there is a minor decrease in inlined constants and in the total instructions. total lits in shared programs: 4328 -> 4194 (-3.10%) lits in affected programs: 554 -> 420 (-24.19%) total instructions in shared programs: 155488 -> 155361 (-0.08%) instructions in affected programs: 5707 -> 5580 (-2.23%) Additonally, a fix for pair translation is needed since the constant inlining can now produce swizzles like this: 4.000000 (0x48).w-0-0-_ so we have to teach pair translation to also ignore the sign for zero swizzle. Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip@gawin.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17560>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.