Leandro Ribeiro
abc464f3a9
In the following commits we add dma-buf feedback support. In order to do that, we need to keep the feedback tied to the lifetime of the surface, instead of tied to the lifetime of the chain. Why do we need this change? The reason is per-surface feedback and swapchain re-creation. If we receive feedback and return SUBOPTIMAL to the client in the next acquireNextImage() call, it may re-create the swapchain. If it doesn't pass us the oldSwapchain, we won't have access to the surface feedback data (as it was tied to the oldSwapchain). We could bind again to the surface feedback, but compositors may have a transient state when we bind to surface feedback, and send a non-optimal batch of dma-buf feedback which is updated when the drawing loop starts. So we would re-create the chain with this non-optimal batch, and after a few moments receive new feedback. This could potentially lead into an allocation loop, so it is not safe. Tying the feedback to the lifetime of the VkSurface we don't have to re-bind to the surface dma-buf feedback every time that the swapchain is re-created, avoiding this dangerous allocation loop described above. So add struct wsi_wl_surface in order to add support for dma-buf feedback. For now it is just the stub, but in the next commits we start making use of that. Reviewed-by: Simon Ser <contact@emersion.fr> Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12226>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.