a51d061c00
0e3e5146cf("intel/brw: Use correct instruction for value change check when coalescing") enabled some new cases that exposed a pre-existing bug that would turn something like this : mul.sat(16) %789:F, %787:F, %788:F mov.g.f0.0(16) %790:F, %789:F (+f0.0) sel(16) %800:UD, %790:UD, 0u into this : mul.sat(16) %790:F, %787:F, %788:F mov.g.f0.0(16) null:F, null<8,8,1>:F (+f0.0) sel(16) %800:UD, %790:UD, 0u The mov[] array can contain the same instruction because it's repeated for each REG_SIZE writes and a SIMD16 instruction will write 2 REG_SIZE. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes:0e3e5146cf("intel/brw: Use correct instruction for value change check when coalescing") Cc: mesa-stable Reviewed-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35276>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.