9f767db126
Currently, negative array texture indices get saturated to 0 which, while technically in-bounds, isn't what we want for Vulkan with image robustness or robustness2. Vulkan requires that a negative index on a texelFetch() count as out-of-bounds but a negative index on any other texture operation gets clamped to 0. (See the spec section entitled "(u,v,w,a) to (i,j,k,l,n) Transformation And Array Layer Selection"). Instead of using CVT for TXF, we now take U32 MAX with 0xffff. Because it's unsigned, this ensures that negative array indices clamp to 0xffff and will be considered out-of-bounds by the hardware (there are a maximum of 2048 array indices in an image descriptor). For everything other than TXF, we keep using an F32->U16 conversion but add a saturate. This ensures that negative array indices clamp to 0 as per the Vulkan spec. Very large indices will clamp to 0xffff which the hardware will clamp to the maximum array index. This fixes 324 tests in the dEQP-VK.robustness.* group, all those for 1D and 2D array textures Acked-by: M Henning <drawoc@darkrefraction.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24593>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.