9ced3148ca
After commit2dcd6bed6a("util: enforce unreachable()'s argument being a literal string", 2023-04-17) the compiler effectively emit errors when an argument that is not a string literal is passed to UNREACHABLE(str), however the compiler still allows the macro to be called without arguments, which can be confusing. Implement the type check outside of the assert() call so that we have two types of errors: 1. The compiler will error out when the argument passed to the macro is not a string literal because the concatenation with an empty string will not be allowed. 2. The compiler will error out when no arguments are passed to the macro because the invocation of assert() will be invalid. This also has the nice side-effect of removing the extra empty string printed in the assert() messages; after the changes the messages will look like: Assertion `!"Invalid type"' failed. instead of: Assertion `!"" "Invalid type"' failed. Fixes:2dcd6bed6a("util: enforce unreachable()'s argument being a literal string", 2023-04-17) Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.