92e1981a80
PSIZ output is only needed when: 1. There is a next stage and it reads it. 2. Primitive topology is point list, in the last vertex pipeline stage. Zink always adds this output in its vertex (and other) shaders, because it helps Zink avoid recompiling shader variants. However, this has a performance impact for RADV because it needs a scalar memory load. That becomes noticeable at high primitive rates. The Fossil stats are unremarkable because our DB doesn't include any shaders from Zink or D9VK, but there are a few affected shaders. Note that there may be an increase in LDS use in some GS. This is because with PSIZ removed the ES per-vertex LDS size is smaller, so we can squeeze more GS threads in the same workgroup. Fossil DB stats on Sienna Cichlid: Totals from 14 (0.01% of 128647) affected shaders: CodeSize: 119884 -> 119732 (-0.13%) LDS: 235008 -> 228864 (-2.61%); split: -2.83%, +0.22% Instrs: 23076 -> 23048 (-0.12%) Latency: 71667 -> 71625 (-0.06%) InvThroughput: 19155 -> 18870 (-1.49%) Copies: 1586 -> 1572 (-0.88%) Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10725>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.