Eric Anholt
82392e0bb9
This atom tries to unbind cb0 when it's not used any more (the params && params->NumParameters check), but if you transitioned to not having a gs/tess enabled at all, you'd skip unbinding it. This was mostly harmless, since if you don't have a GS, why are you looking at GS constants? However, if a new program came along that didn't use cb0 at all, we wouldn't end up in this atom to get the disable, and now you have a GS enabled but a GS constbuf pointing at potentially freed data. Dereferencing the freed cb0 data ended up happening in freedreno's fallback UBO upload path with this combination of tests (which execute in that order): dEQP-GLES31.functional.shaders.opaque_type_indexing.sampler.uniform.geometry.sampler2darray dEQP-GLES31.functional.shaders.opaque_type_indexing.ubo.const_literal_fragment dEQP-GLES31.functional.shaders.opaque_type_indexing.ubo.dynamically_uniform_geometry and it seems also affected softpipe as well. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9070>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.