Mary Guillemard
800a861431
We have a lot of pattern like this on Valhall: FCMP_OR.f32.lt.m1 r28, ^r28, r27, 0x0 FCMP_OR.f32.lt.m1 r29, r27, r25, 0x0 LSHIFT_AND.i32 r28, ^r28, 0x0.b00, ^r29 That can be simplified into: FCMP_OR.f32.lt.m1 r29, r27, r25, 0x0 FCMP_AND.f32.lt.m1 r28, ^r28, r27, ^r29 This pass merge those specific cases while setting the appropriate logical variant of the CMP instruction. We do not try to merge the srcs that do not originate from a matching CMP instruction with matching result type as the logical operation is performed before the result type transformation. Now this is enough to optimise a lot of common cases anyway so it is still a win. Results on fossils/sascha-willems: Totals: Instrs: 42157 -> 42059 (-0.23%) CodeSize: 582784 -> 581760 (-0.18%) Estimated normalized SFU cycles: 159.9375 -> 153.75 (-3.87%) Totals from 13 (2.07% of 627) affected shaders: Instrs: 3490 -> 3392 (-2.81%) CodeSize: 29696 -> 28672 (-3.45%) Estimated normalized SFU cycles: 15.8125 -> 9.625 (-39.13%) Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com> Reviewed-by: Eric R. Smith <eric.smith@collabora.com> Reviewed-by: Olivia Lee <olivia.lee@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36327>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.