Alyssa Rosenzweig
7edd42cbc0
Move the decision of "can I copyprop this uniform?" from copyprop to a standalone lowering pass. This is more straightforward and will enable the next patch. This has the side effect of sinking load_preamble instructions, for a nice reduction in register pressure. Instruction count increase is from rematerializing some moves, which should be more than balanced out by the reduced register pressure. total instructions in shared programs: 1523285 -> 1523317 (<.01%) instructions in affected programs: 1148 -> 1180 (2.79%) helped: 0 HURT: 13 HURT stats (abs) min: 1.0 max: 4.0 x̄: 2.46 x̃: 2 HURT stats (rel) min: 0.69% max: 7.69% x̄: 3.65% x̃: 2.61% 95% mean confidence interval for instructions value: 1.78 3.14 95% mean confidence interval for instructions %-change: 2.16% 5.15% Instructions are HURT. total bytes in shared programs: 10444532 -> 10444724 (<.01%) bytes in affected programs: 7386 -> 7578 (2.60%) helped: 0 HURT: 13 HURT stats (abs) min: 6.0 max: 24.0 x̄: 14.77 x̃: 12 HURT stats (rel) min: 0.63% max: 7.14% x̄: 3.40% x̃: 2.48% 95% mean confidence interval for bytes value: 10.68 18.85 95% mean confidence interval for bytes %-change: 2.02% 4.78% Bytes are HURT. total halfregs in shared programs: 419444 -> 416434 (-0.72%) halfregs in affected programs: 27080 -> 24070 (-11.12%) helped: 634 HURT: 0 helped stats (abs) min: 1.0 max: 30.0 x̄: 4.75 x̃: 2 helped stats (rel) min: 2.90% max: 54.55% x̄: 13.13% x̃: 8.51% 95% mean confidence interval for halfregs value: -5.08 -4.41 95% mean confidence interval for halfregs %-change: -14.03% -12.23% Halfregs are helped. Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21122>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.