Iago Toral Quiroga
7e0616ecc5
If the shader writes point size, then the compiler needs to ensure it writes it in the appropriate vpm output slot and also clamp its value to expected limits. This is why we have the per_vertex_point_size in the shader key, so it doesn't really make sense to set this if the shader doesn't write point size. If the shader record flags that the shader writes point size then the hardware will use the shader written value to override point size state (set with the POINT_SIZE packet), so again, we really only want to set this in the shader state record if the shader actually writes its value. While we could also limit this to point primitives, since these are the only primitives where point size has an effect, this is not really required, and skipping this allows us to use the same shader with any primitive type (otherwise we would have to compile 2 different shaders). Finally, this change makes the vertex shader setup for point size match the one we had been doing for geometry shaders, so it makes both stages behave consistently regarding point size behavior. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29413>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.