Yiwei Zhang
60f513279c
Spec requires apps to use the size returned from vkGetAndroidHardwareBufferPropertiesANDROID for AHB import, which includes dedicated image/buffer import and non-dedicated buffer import. Spec requires venus to use the size from image and buffer memory requirement for dma_buf fd import if it's dedicated. If not dedicated, the actual payload size should be used. For AHB export allocation of VkImage, the app provided size will be 0, and internally we must use the size from image memory requirement. For AHB export allocation of VkBuffer, the app provided size comes from buffer memory requirements and it can be smaller than the actual AHB size due to page alignment. Internally that's the size we must use. For AHB import, app must use the size from AHB prop query. Internally, we have to override that with the size from memory requirement if the import operation is dedicated to a VkImage or a VkBuffer. If not dedicated, the actual payload size should be used. The not working scenario is: 1. App creates an AHB backed VkBuffer, and the exported AHB size is larger than the buffer memory requirement (very common). 2. App imports the AHB without a dedicated VkBuffer. Then the entire AHB payload will be imported and the mmap_size might increase. Test: dEQP-VK.api.external.memory.android_hardware_buffer.* Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org> Reviewed-by: Chia-I Wu <olvaffe@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11055>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.