Danylo Piliaiev
6003a89b89
Otherwise we can have a case where binning VS uses more consts than full VS (when safe variant is used for full VS), that will result in a rendering issue because SP_VS_CONST_CONFIG.CONSTLEN is shared between full and binning VS in PROGRAM_CONFIG state and gets the value from the full VS. There are two alternative solutions that can allow binning VS to always use maximum constlen: - Move constlen emission to per-XS config. This interferes PROGRAM_CONFIG state which uploads consts and does SP_UPDATE_CNTL. Consts would need to be uploaded after constlen is defined, while SP_UPDATE_CNTL must be done before per-XS state is emitted. Also having SP_UPDATE_CNTL in a draw state that is always DIRTY isn't great. Something didn't work out on A6XX, so this idea was dropped. - Emit constlen again in VS_BINNING draw state. This seem to work but also likely an undefined behaviour since constlen is changed after some consts are uploaded. Cc: mesa-stable Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36203>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.