Antonio Ospite
5c019bdee5
When building nvk for Android the rust compiler emits the following
errors:
-----------------------------------------------------------------------
error: methods `get_pred_src`, `get_u32_bnot_src`, `get_carry_src`, `set_pred_dst`, and `set_carry_dst` are never used
--> ../src/nouveau/compiler/nak/ir.rs:1371:12
|
1370 | impl OpFoldData<'_> {
| ------------------- methods in this implementation
1371 | pub fn get_pred_src(&self, op: &impl SrcsAsSlice, src: &Src) -> bool {
| ^^^^^^^^^^^^
...
1404 | pub fn get_u32_bnot_src(&self, op: &impl SrcsAsSlice, src: &Src) -> u32 {
| ^^^^^^^^^^^^^^^^
...
1413 | pub fn get_carry_src(&self, op: &impl SrcsAsSlice, src: &Src) -> bool {
| ^^^^^^^^^^^^^
...
1446 | pub fn set_pred_dst(&mut self, op: &impl DstsAsSlice, dst: &Dst, b: bool) {
| ^^^^^^^^^^^^
...
1450 | pub fn set_carry_dst(&mut self, op: &impl DstsAsSlice, dst: &Dst, b: bool) {
| ^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
error: method `eval` is never used
--> ../src/nouveau/compiler/nak/ir.rs:1523:12
|
1522 | impl PredSetOp {
| -------------- method in this implementation
1523 | pub fn eval(&self, a: bool, b: bool) -> bool {
| ^^^^
error: method `to_mask` is never used
--> ../src/nouveau/compiler/nak/ir.rs:5625:12
|
5614 | impl SuClampRound {
| ----------------- method in this implementation
...
5625 | pub fn to_mask(&self) -> u32 {
| ^^^^^^^
error: method `cast` is never used
--> ../src/nouveau/compiler/nak/ir.rs:6041:8
|
6006 | impl IMadSpSrcType {
| ------------------ method in this implementation
...
6041 | fn cast(&self, v: u32) -> i64 {
| ^^^^
-----------------------------------------------------------------------
Add `#[allow(dead_code)]` to silence the errors, as suggested by the
compiler.
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Mel Henning <mhenning@darkrefraction.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36849>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.