Pavel Ondračka
558f632967
NIR-to-TGSI produces partial output writes contrary to the old paths that always wrote the full outputs. Therefore if there is now a partial output write ready to be scheduled and nothing else besides a tex is ready, we would schedule the output write first. This was not a problem before as usually at last some component of the full output write depended on the tex result. This is not optimal from the performance point of view and resulted in ~20% slowdown in the Unigine demos. The docs say: The first OUTPUT instruction will reserve space in the output register fifo. This space is limited, therefore issuing an OUTPUT earlier than necessary may cause threads to stall earlier than necessary. You should not set an ALU instruction as type OUTPUT unless it is actually writing to an output register, or it is the last instruction of the program. Fix it by explicitly prefering a TEX before OUT and restore the performance: 9.66 -> 12.12 fps (as compared to 11.83 with the old glsl-to-TGSI path) in Unigine Sanctuary. No change in Lightsmark or GLmark. This is also a win from the intructions point of view as we are usually able to schedule the partial output writes in a single pair at the end. total instructions in shared programs: 106009 -> 105891 (-0.11%) instructions in affected programs: 10153 -> 10035 (-1.16%) helped: 118 HURT: 0 Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5840 Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15165>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.