Pavel Ondračka
5115cebd5d
The HW can't do comparison opcodes in the FS, so the old way was to lower all to ADD and CMP in the backend. However, the comparison bool result is used either in if (where we can encode the comparions in the aluresults calculation) or is uses in another bcsel. Therefore, we now end with two CMPs, one from the original bcsel and one from the lowered comparison. This patch fixes it by doing the comparison lowering early for some nice shader-db gains. Similarly to vertex shaders, we need some special passes for this, because we can't nir_lower_bool_to_float too early, so we just manually lower the most common patterns in the main opt loop and than clean up the rest later. Shader-db RV530: total instructions in shared programs: 130797 -> 130400 (-0.30%) instructions in affected programs: 34591 -> 34194 (-1.15%) helped: 203 HURT: 133 total presub in shared programs: 8175 -> 8220 (0.55%) presub in affected programs: 1738 -> 1783 (2.59%) helped: 62 HURT: 53 total omod in shared programs: 414 -> 412 (-0.48%) omod in affected programs: 4 -> 2 (-50.00%) helped: 2 HURT: 0 total temps in shared programs: 17570 -> 17566 (-0.02%) temps in affected programs: 1122 -> 1118 (-0.36%) helped: 41 HURT: 43 total consts in shared programs: 94362 -> 94359 (<.01%) consts in affected programs: 381 -> 378 (-0.79%) helped: 13 HURT: 10 total lits in shared programs: 2951 -> 2961 (0.34%) lits in affected programs: 104 -> 114 (9.62%) helped: 3 HURT: 9 total cycles in shared programs: 198965 -> 198744 (-0.11%) cycles in affected programs: 55784 -> 55563 (-0.40%) helped: 177 HURT: 144 LOST: 0 GAINED: 1 Shader-db RV380: total instructions in shared programs: 84224 -> 84109 (-0.14%) instructions in affected programs: 6039 -> 5924 (-1.90%) helped: 106 HURT: 38 total presub in shared programs: 1401 -> 1372 (-2.07%) presub in affected programs: 113 -> 84 (-25.66%) helped: 27 HURT: 10 total temps in shared programs: 13231 -> 13224 (-0.05%) temps in affected programs: 303 -> 296 (-2.31%) helped: 22 HURT: 12 total consts in shared programs: 82484 -> 82505 (0.03%) consts in affected programs: 271 -> 292 (7.75%) helped: 4 HURT: 25 total cycles in shared programs: 132957 -> 132840 (-0.09%) cycles in affected programs: 12696 -> 12579 (-0.92%) helped: 101 HURT: 43 LOST: 0 GAINED: 1 Signed-off-by: Pavel Ondračka <pavel.ondracka@gmail.com> Reviewed-by: Filip Gawin <filip.gawin@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27089>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.