Brian Paul
4e2d88781d
The nir code for AOS (aka linear) mode had a number of issues. In some cases, the RGB->BGR swizzling wasn't happening, leading to incorrect colors. In other cases, bad swizzling caused the first pixel's color to be written to four adjacent pixels. Writemasks must also be swizzled. For example, if an instruction's writemask indicates the X component but the AOS component order is BGRA we need to change the writemask to Z. Another issue was with constant buffer values not getting consistently convert to BGRA order. Fixing this involves removing the lp_nir_aos_conv_const() function and immediately converting immediate values from 4 x f32 in [0,1] to 16 x u8 when we translate nir's load_const so that we know the value is in the right linear/AOS layout right away. Finally, the llvmpipe_nir_fn_is_linear_compat() function was not checking that nir_instr_type_load_const values are in [0,1] for AOS execution. The info.unclamped_immediates field is not needed for the NIR path (but still used for the old TGSI path). This fixes quite a few tests in our VMware suite. Signed-off-by: Brian Paul <brianp@vmware.com> Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18213>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.