Iago Toral Quiroga
3fb9e27a3d
The RAM shader cache was using the v3d_key for hashes and comparisons which is not correct. Particularly, this struct has a void pointer where we store a reference to an uncompiled shader with the NIR code, and that is of course not accounted for when hashing and comparing keys, which can lead to bogus cache hits. This patch introduces a v3d_cache_key that has both the v3d key and a sha1 of the uncompiled NIR. Now key hashing and comparison is done on the static part of the v3d key (that is, excluding the uncompiled shader pointer, which may be invalid in the cache if the original shader was deleted) and taking the sha1 from the uncompiled shader. This also makes sure the shader key we store in the cache has a NULL shader_state pointer to make it more clear that this field may not be used at all for caching purposes. This fixes GPU hangs with some OpenCL tests (through Rusticl) caused by incorrect RAM cache hits. Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25418>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.