Autumn Ashton
3d75082c02
When we are using compute resolve, we can get values the CTS does not expect due to the value we end up writing for UNORM in `nir_image_deref_store`. Make the compute resolve rounding path match with the output of the fragment shader resolve path, by going through the same FP16 RTZ conversion as we do for UNORM/SNORM formats. This is why VK_EXT_sample_locations CTS was failing on > GFX9. On <= GFX9, I am assuming we are falling back to RESOLVE_FRAGMENT, due to DCC stuff, which is why it works there. I tested a handful of images from the Vulkan CTS for the sample locations and resolve tests for diff UNORM formats from the qpa file forcing FRAGMENT and with this change. With this change, we now match on the compute resolve path the same sha for the ones I compared with ImageMagick `identify`. CTS passes for: *resolve*, *image_clearing* and *sample_locations* on RX 7900XTX. Signed-off-by: Autumn Ashton <misyl@froggi.es> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28237>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.