Samuel Pitoiset
3ca2f71f3d
When the hardware doesn't natively support 32-bit predication, the driver has a fallback which allocates a 64-bit predicate to the upload BO in order to copy the original value. But when conditional rendering is enabled in the stateCommandBuffer which is used by preprocess() and the execute() is recorded also in the stateCommandBuffer. If the preprocess() is recorded in a different cmdbuf which is submitted before the cmdbuf that contains execute(), the fallback (ie. alloc + COPY_DATA) will be performed after. This would cause the predicate value to be always 0. To fix that, keep track of the user predication VA which is the only VA that needs to be used by DGC because it reads 32-bit from the shader. This fixes a very weird corner case with vkd3d-proton. Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13143 Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34953>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.