Alejandro Piñeiro
36c547342a
That is what most others Vulkan drivers do (radv, anv, turnip at least). The origin of this change cames from a CTS test where the loop unrolling converted a ubo index defined inside a loop from constant to non constant. That is not desiderable on any driver, but a problem on v3dv, as v3dv doesn't support that case. Although we initially tried to fix it on the loop unroll, we discarded that approach, and focused on the existing nir lowerings/optimizations as this was not happening with other drivers. We noted that in other drivers this case of a ubo index going from const to non-const were also happening with nir_lower_explicit_io, but in that case it was able to be converted back to a const on following lowerings. The only difference with other drivers is that we were calling it before the first nir optimization loop. So this change helps with fixing the following CTS test (for that we also need to run additional lowerings, which we do in a later patch): dEQP-VK.graphicsfuzz.cov-loop-condition-clamp-vec-of-ones You can get further details on the following issue and RFC merge request, specially the merge request: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6051 https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15391 We also made some shaderdb stats with our usual Vulkan apps (ue4 demos, quake3, etc): Total instructions in shared programs: 125014 -> 124974 (-0.03%) instructions in affected programs: 7544 -> 7504 (-0.53%) helped: 7 HURT: 4 total uniforms in shared programs: 19026 -> 19019 (-0.04%) uniforms in affected programs: 514 -> 507 (-1.36%) helped: 5 HURT: 0 total max-temps in shared programs: 13430 -> 13438 (0.06%) max-temps in affected programs: 270 -> 278 (2.96%) helped: 0 HURT: 8 total sfu-stalls in shared programs: 739 -> 741 (0.27%) sfu-stalls in affected programs: 30 -> 32 (6.67%) helped: 0 HURT: 2 total inst-and-stalls in shared programs: 125753 -> 125715 (-0.03%) inst-and-stalls in affected programs: 7685 -> 7647 (-0.49%) helped: 7 HURT: 4 total nops in shared programs: 8228 -> 8203 (-0.30%) nops in affected programs: 546 -> 521 (-4.58%) helped: 9 HURT: 2 Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16986>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.