3497069a04
This is complicated by two things: mediump varyings, and the lack of u16 regfmt support in LD_VAR. With mediump, a load(_interpolated)_input with a 16-bit dest size may either be an explicit 16-bit type or a mediump type lowered by nir_lower_mediump_io. With explicit 16-bit types, we write 16-bit values in the VS, but with mediump we write 32-bit in the VS (for messy reasons). bi_emit_load_vary needs to distinguish these cases by checking for a mediump type, and set the appropriate source_format to convert the type on the LD_VAR_BUF path. Types like 'mediump uint16' are luckily not allowed. The missing u16 regfmt for LD_VAR means that we take the obvious approach for 16-bit int varyings of emitting 16-bit int formats in the attribute descriptor and loading them to u16. Instead, we just write/read all 16-bit varyings as f16 regardless of type. Unlike with mediump, we don't need to do any 32bit->16bit conversion when loading in the FS, so as long as we use the same type between the attribute descriptor and LD_VAR, the conversion is a no-op and the mismatch doesn't matter. Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com> Reviewed-by: Lars-Ivar Hesselberg Simonsen <lars-ivar.simonsen@arm.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33078>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.