Caio Oliveira
2dfd4dcbc5
The HW only supports converting BRW_TYPE_BF values to/from BRW_TYPE_F, so intermediate conversion is needed. Move the intermediate conversion to the implementation of `@convert_cmat_intel` and simplify the brw_nir_lower_cooperative_matrix pass. This has two positive effects - Fixes conversion between BF and integer type cooperative matrices, that was still using the old emit_alu1 approach instead of the new code for `@convert_cmat_intel`. - Guarantee the intermediate conversion will result in a valid layout for conversions involved USE_B matrices. If we instead used the intrinsic twice in brw_nir_lower_cooperative_matrix.c, a matrix with invalid layout would be visible at NIR level and we wouldn't be able to keep the current assertion for USE_B case. Due to the configurations we have exposed, we still don't need to write a more complex USE_B conversion -- they are all between same size types (and, consequently, packing factors), so no shuffling of data is needed to respect the USE_B layout. Reviewed-by: Matt Turner <mattst88@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36185>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.