Pierre-Eric Pelloux-Prayer
2a381bbc3c
si_destroy_context needs to call context->set_debug_callback(...) to avoid the debug logs to access the destroyed context. Adding this change introduced a different problem: when an aux context is destroyed from si_destroy_screen, parts of the screen have been freed already: the shader_compiler_queue_*.c467a87e06("radeonsi: Destroy queues before the aux contexts") moved the util_queue_destroy calls above the context destruction, but with the59a3f38ff6change, it's not needed anymore: si_destroy_context will finish the screen shader queues before proceeding with releasing, so use-after-free isn't possible. Fixes:59a3f38ff6("radeonsi: clear the debug callback on ctx destroy") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12035 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34574>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.