Paulo Zanoni
1d23cf192b
I dumped assembly generated by our driver with INTEL_DEBUG=shaders, copied and pasted it into a lua file, tried to run it with src/intel/executor, but the disassembler started telling me some instructions were invalid. This happened because we print the "compacted" flag in our assembly text, so when brw_gram.y parses our assembly flag, it sees the "compacted" flag and sets it to the instruction by calling add_instruction_option(). But the executor tool never sets the BRW_ASSEMBLE_COMPACT flag when it calls brw_assemble(), so when brw_assemble() calls dump_assembly(), which calls brw_disassbemble(), the disassembler gets confused and prints misinterpreted instructions and calls them invalid. It is not the job of brw_gram.y (our text assembly parser) to mark instructions as compacted. Whatever is later assembling the instruction is the entity that should decide if the instructions are compacted or not. So in this patch we just ignore this flag. Reviewed-by: Caio Oliveira <caio.oliveira@intel.com> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33614>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.