Vinson Lee
191e4b8fe0
Commite626636e90("bin/symbols-check: fix fields length condition before accessing fields") changed the condition from `or` to `and` to prevent potential IndexError when accessing fields[1]. However, this broke macOS because `nm -gP` outputs different field counts for undefined symbols: - Linux: `_symbol U` (2 fields) - macOS: `_symbol U 0 0` (4 fields) The condition `len(fields) == 2 and fields[1] == 'U'` only matched the Linux format, causing undefined symbols like _mesa_glapi_tls_Dispatch to be incorrectly reported as "unknown symbol exported" on macOS. Fix by using `len(fields) >= 2` to handle both platforms while still guarding against IndexError. Fixes:e626636e90("bin/symbols-check: fix fields length condition before accessing fields") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/13451 Signed-off-by: Vinson Lee <vlee@freedesktop.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38983>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.