Alyssa Rosenzweig
1786032029
Profiling showed that maintaining this ssa_srcs set consumes ~3% of CTS time with a debugoptimized build. Unfortunately, we really do benefit from getting this coverage in CI. So rather than remove the validation, let's optimize the data structure used so we can keep the coverage at a fraction of the cost. The expensive piece is the pointer set, which is backed by a relatively expensive hash table. It would be much cheaper to use an invasive set instead, with a single "present" bit. We don't want to bloat nir_src for this, however there's an easy solution: use a tagged pointer to steal a bit in the nir_src for the job. We untag everything at the end of validation (and this meta-invariant is asserted with an auxiliary counter), so while we mutate the IR while validating, the mutations do not escape nir_validate. We tag the parent pointer and not the def pointer, because it is dramatically less used and therefore has far fewer disrupted call sites. The M1 job is improved from 3:03 to 2:55 of deqp-runner reported time, which is excellent. Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26084>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.