Pierre-Eric Pelloux-Prayer
115b61e51f
Yet another iteration on the same YUV surfaces. The change from87ecfdfbf0has 2 odd things: * it's using MAX2(original value, new value) but the point of updating surf_slice_size / surf_size is to make it correct relative to the new value of surf_pitch * it's multiplying surf_pitch (= number of elements per row) by height (ok) by surf->bpe (= number of bytes per element) by surf->blk_w (= number of "horizontal" pixels in an element) so the end unit doesn't make sense. Fix this by computing a reasonnable value based on unit: the surf_slice_size is the number of elements per row (surf_pitch) x number of bytes per element (bpe) x number of rows. This makes the expected size correct and thus fixes users of eglCreateImageKHR, like the issue #6131. I tested a bunch of gst pipelines and ffmpeg scripts on various files I have and didn't notice any issues (on gfx10.3 and gfx9). Fixes:87ecfdfbf0("ac/surface: adapt surf_size when modifying surf_pitch") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/6131 Acked-by: Marek Olšák <marek.olsak@amd.com> Tested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26693>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.