08581e2e92
Before this commit, zink_format_clamp_channel_color() ignored the format swizzle, so it was assuming that for emulated formats like alpha, alpha-luminance etc. that the color had already been swizzled to match the internal format rather than the emulated one. It's somewhat confusing that passing in e.g. A8_UNORM actually means R8_UNORM, and led to a bug when using VK_FORMAT_A8_UNORM for texture border colors because we didn't swizzle it back. It also wouldn't have worked for media formats like R10X6G10X6 due to the void channel in the middle. In order to fix this, we need to untangle the mess in its users. For convert_color() used when clearing, this means we now need to clamp and then swizzle instead of swizzle and then clamp, and we can drop the hack for A8_UNORM. For texture border colors, the state tracker duplicates colors for the emulated formats to help drivers, which zink was previously relying on, but fixing zink_format_clamp_channel_color() breaks this because it assumes that those duplicated colors are useless and clamps them. However, because we know the format we can just swizzle the border color ourself, which convert_color() was already doing. So, we pull that out into a common zink_convert_color() function that handles both clamping and format emulation, and have both clearing and border color handling use it. This fixes A8_UNORM in turnip+zink once we enable it. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25001>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.