Alyssa Rosenzweig
056e8ec8c3
If we have multiple reads of the same SSA def in the same block, we don't need to emit multiple copies for it, we can just reuse a copy (OR'ing in the mask, knowing the source is already fully written since it's SSA). This will prevent some regressions in moves from the copyprop patch. There is a bit of a tradeoff here between increased pressure and reduced instruction count but I'm not too worried. The affect on pressure seems all over the place -- register use decreases overall, threads increase (great!) but a few shaders that were *already spilling*, spill a bit worse. I'm not terribly worried there. total instructions in shared programs: 1518289 -> 1514856 (-0.23%) instructions in affected programs: 292854 -> 289421 (-1.17%) helped: 1557 HURT: 232 Instructions are helped. total bundles in shared programs: 646903 -> 645327 (-0.24%) bundles in affected programs: 91872 -> 90296 (-1.72%) helped: 910 HURT: 256 Bundles are helped. total quadwords in shared programs: 1133728 -> 1130554 (-0.28%) quadwords in affected programs: 187170 -> 183996 (-1.70%) helped: 1399 HURT: 44 Quadwords are helped. total registers in shared programs: 90640 -> 90559 (-0.09%) registers in affected programs: 2676 -> 2595 (-3.03%) helped: 202 HURT: 124 Inconclusive result (%-change mean confidence interval includes 0). total threads in shared programs: 55561 -> 55590 (0.05%) threads in affected programs: 50 -> 79 (58.00%) helped: 23 HURT: 6 Threads are helped. total spills in shared programs: 1386 -> 1402 (1.15%) spills in affected programs: 231 -> 247 (6.93%) helped: 2 HURT: 13 total fills in shared programs: 5159 -> 5285 (2.44%) fills in affected programs: 1282 -> 1408 (9.83%) helped: 11 HURT: 16 Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io> Reviewed-by: Italo Nicola <italonicola@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23769>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.