Alejandro Piñeiro
03f5fae88f
In order to properly check (and possibly compile) shader variants we need a pipeline and a compatible descriptor set. So far we were trying to do that check as early as possible, so we were trying to do it at CmdBindPipeline or CmdBindDescriptorSets, and a combination of dirty flags. This showed to not cover all the corners cases, and made the code complex, as needed to handle cases where the descriptors were not yet available, and return early. The latter also meant that we were running several checks that failed in the middle. This commit moves the variant check to CmdDraw, when we should have a pipeline and compatible descriptor sets, and simplifies and makes more strict the existing code. Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://mesa3d.org/meson.html>`_): .. code-block:: sh $ mkdir build $ cd build $ meson .. $ sudo ninja install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `Freenode's #dri-devel <irc://chat.freenode.net#dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.