Mark Collins
0342d34bdb
The fast path for kgsl_queue_submit when there are no command buffers and only sync objects led to breakage for two reasons: * The fast path was not properly handling duplication of the merged sync object assigned to signalled `kgsl_syncobj`(s), which could lead to multiple `kgsl_syncobj`s owning the same FD and consequently issues such as double close of that FD leading to UB. This is fixed by moving to the slow path as it always produces a timestamp sync object which can be trivially duplicated. * The Vulkan specification requires that drivers strictly follow the order of submission of command buffers and consequently the order of semaphore signal/wait operations. Since no submission was being made to the kernel, subsequent submissions could be executed without waiting for wait/signal operations from previous submissions to complete. As both of these issues are fixed by moving to the slow path, this patch removes the fast path in favor of the more correct slow path. Signed-off-by: Mark Collins <mark@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33894>
`Mesa <https://mesa3d.org>`_ - The 3D Graphics Library ====================================================== Source ------ This repository lives at https://gitlab.freedesktop.org/mesa/mesa. Other repositories are likely forks, and code found there is not supported. Build & install --------------- You can find more information in our documentation (`docs/install.rst <https://docs.mesa3d.org/install.html>`_), but the recommended way is to use Meson (`docs/meson.rst <https://docs.mesa3d.org/meson.html>`_): .. code-block:: sh $ meson setup build $ ninja -C build/ $ sudo ninja -C build/ install Support ------- Many Mesa devs hang on IRC; if you're not sure which channel is appropriate, you should ask your question on `OFTC's #dri-devel <irc://irc.oftc.net/dri-devel>`_, someone will redirect you if necessary. Remember that not everyone is in the same timezone as you, so it might take a while before someone qualified sees your question. To figure out who you're talking to, or which nick to ping for your question, check out `Who's Who on IRC <https://dri.freedesktop.org/wiki/WhosWho/>`_. The next best option is to ask your question in an email to the mailing lists: `mesa-dev\@lists.freedesktop.org <https://lists.freedesktop.org/mailman/listinfo/mesa-dev>`_ Bug reports ----------- If you think something isn't working properly, please file a bug report (`docs/bugs.rst <https://docs.mesa3d.org/bugs.html>`_). Contributing ------------ Contributions are welcome, and step-by-step instructions can be found in our documentation (`docs/submittingpatches.rst <https://docs.mesa3d.org/submittingpatches.html>`_). Note that Mesa uses gitlab for patches submission, review and discussions.