Eric Engestrom
fbd644c59d
meson: replace vk_wsi_args with dependencies to let meson take care of transitivity
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19497 >
2023-02-23 09:42:46 +00:00
Eric Engestrom
f059213f5d
meson: reuse vulkan_wsi_list for defining vk_wsi_args
...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19497 >
2023-02-23 09:42:46 +00:00
Eric Engestrom
22c1f4be8c
docs: mention meson configure and drop broken workaround script
...
The script is broken, and nobody noticed so it wasn't used much.
Meson has had support for printing the options by pointing to the source
dir for a while (not sure the exact version though) so I think we can
just recommend users do that.
Signed-off-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21469 >
2023-02-23 08:50:40 +00:00
Eric Engestrom
e5cf283121
docs: mention the meson summary
...
Signed-off-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21469 >
2023-02-23 08:50:40 +00:00
Marcin Ślusarz
512126b26d
intel/compiler: remove unused field from fs_thread_payload
...
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20957 >
2023-02-23 08:04:24 +00:00
Patrick Lerda
9b4eb73907
r600: fix shader blob memory leak
...
Fixes: 5b205ef413
r600: Store nir shaders serialized to save memory
Direct leak of 4096 byte(s) in 1 object(s) allocated from:
#0 0x7faf89c3bb48 in __interceptor_realloc (/usr/lib64/libasan.so.6+0xb1b48)
#1 0x7faf7be5981d in grow_to_fit ../src/util/blob.c:67
#2 0x7faf7be5a538 in grow_to_fit ../src/util/blob.c:49
#3 0x7faf7be5a538 in blob_reserve_bytes ../src/util/blob.c:177
#4 0x7faf7be5a538 in blob_reserve_uint32 ../src/util/blob.c:190
#5 0x7faf7d248a8c in nir_serialize ../src/compiler/nir/nir_serialize.c:2109
#6 0x7faf7df4fdbb in r600_pipe_shader_create ../src/gallium/drivers/r600/r600_shader.c:401
Signed-off-by: Patrick Lerda <patrick9876@free.fr >
Reviewed-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21443 >
2023-02-23 07:06:42 +00:00
Juston Li
cc3c97d8c9
venus: Add VkBuffer cache statistics for debug
...
Signed-off-by: Juston Li <justonli@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21324 >
2023-02-23 03:38:10 +00:00
Juston Li
7d53d4d078
venus: add VN_DEBUG_CACHE flag
...
General debug flag for dumping statistics for various caching done by
venus.
Signed-off-by: Juston Li <justonli@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21324 >
2023-02-23 03:38:10 +00:00
Juston Li
ef255444c1
venus: switch to lazy VkBuffer cache
...
Instead of creating a static VkBuffer cache at init with hardcoded
CreateInfo's, lazily cache VkBuffers that the app requests.
Signed-off-by: Juston Li <justonli@google.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21324 >
2023-02-23 03:38:10 +00:00
Karol Herbst
56a9aad401
nir/deref: don't replace casts with deref_struct if we'd lose the stride
...
The result might be used in a deref_ptr_as_array, which requires a proper
stride within lower_explicit_io. If we'd lose that information or end up
with a different stride don't execute this optimization.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8289
Fixes: b779baa9bf ("nir/deref: fix struct wrapper casts. (v3)")
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21458 >
2023-02-23 01:44:25 +00:00
Sajeesh Sidharthan
fa9a8c85e2
radeonsi/vcn: disable fence for JPEG decoding
...
5e1bd07a is causing JPEG decoding regression issue.
Therefore, disable fence for JPEG decoding until fence issue is fixed.
Signed-off-by: Sajeesh Sidharthan <sajeesh.sidharthan@amd.com >
Reviewed-by: Boyuan Zhang <boyuan.zhang@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21442 >
2023-02-23 01:08:09 +00:00
Eric Engestrom
c392cdf750
v3d: update supertuxkart reference after 1c028a4d5b
...
The smoke effect now looks smoother instead of having hard steps, which
looks like a reasonable change given that 1c028a4d5b added
several float formats:
https://eric.pages.freedesktop.org/-/mesa/-/jobs/36691458/artifacts/results/summary/results/trace@broadcom-rpi4@supertuxkart@supertuxkart-mansion-egl-gles-v2.trace.html
Fixes: 1c028a4d5b ("v3d: support r{g,gba}16f formats for vertex buffers")
Signed-off-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21462 >
2023-02-22 23:08:21 +00:00
Sviatoslav Peleshko
4229d9324f
iris: Avoid creating uncompressed view with unaligned tile offsets on BDW
...
Fixes: 60568d5d ("iris: Use isl_surf_get_uncompressed_surf")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7990
Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com >
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21147 >
2023-02-22 22:33:08 +00:00
Eric Engestrom
7ebdddf319
docs: update calendar for 22.3.6
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21477 >
2023-02-22 22:27:27 +00:00
Eric Engestrom
2ad5927816
docs/relnotes: add sha256sum for 22.3.6
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21477 >
2023-02-22 22:27:27 +00:00
Eric Engestrom
e581901132
docs: add release notes for 22.3.6
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21477 >
2023-02-22 22:27:27 +00:00
Emma Anholt
ecabc824c2
glsl: Drop the (v.x + v.y + v.z + v.w) -> dot(v, 1.0) optimization.
...
It's not connected up to anything at the moment, and even if I do enable
it for crocus HSW it only shaves 3 instructions off of one particular VS
in an old synthetic benchmark, not affecting anything else in shader-db.
I don't think anyone will care to ever fix or port this to NIR, let's just
retire it.
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21353 >
2023-02-22 21:45:35 +00:00
Rob Clark
3c668513b9
freedreno/a6xx: Fix view_seqno in tex cache key
...
If the view's seqno increments, it needs to happen *before* the tex cache
key is constructed. Normally this happens when the sampler views are
bound. But if the texture backing a current sampler view is rebound we
need to handle this before the cache lookup.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:28 +00:00
Rob Clark
818b49932a
freedreno/a6xx: Static-ify sampler_view_update()
...
It doesn't need to be visible elsewhere since commit a93d3f1498
("freedreno/a6xx: Move tex state building")
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:28 +00:00
Rob Clark
e9fa92d6fa
freedreno/a6xx: Small cleanup
...
Move the rb allocation to the place where it is populated (ie. where we
know how large it must be).
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:28 +00:00
Rob Clark
936f2ebb46
freedreno/a6xx: Remove needs_invalidate flag
...
Whether the rsc seqno has changed tells us whether we need to update.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rob Clark
b6778995d7
freedreno/a6xx: Add a way to assert valid format
...
Layout transitions caused by access as a various format must happen at
state bind time, before batch_draw_tracking(). Add a helper to assert
this fact.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rob Clark
ea9d1cfb20
freedreno/a6xx: Fix sampler view rsc_seqno for X32_S8X24
...
Elsewhere we are comparing it against the seqno for the "primary" z32
buffer, so be consistent. Otherwise we'll think we need to re-validate
every time the sampler view is bound.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rob Clark
b40e3c9e6c
freedreno/a6xx: Drop unneed fd6_texture_state() arg
...
It is redundant with shader type (stage).
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rob Clark
29445505f6
freedreno/a6xx: Fix set_sampler_views(start != 0)
...
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rob Clark
a3c73987ab
freedreno/a6xx: Move rsc seqno out of tex cache key
...
Since we invalidate tex cache entries if an associated pipe_resource is
rebound, we don't rely on the rsc_seqno being part of the tex cache key.
Signed-off-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21408 >
2023-02-22 21:26:27 +00:00
Rhys Perry
94abccf3ce
aco: fix pathological case in LdsDirectVALUHazard
...
Similar to bfd4ac4581 .
No fossil-db changes.
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Fixes: 296b4d95a3 ("aco/gfx11: workaround LdsDirectVALUHazard")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21423 >
2023-02-22 20:46:12 +00:00
Georg Lehmann
ee47cc8256
amd,nir: remove byte_permute_amd intrinsic
...
It's unused and if we ever want to use it again we should make it an alu
opcode instead.
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Acked-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21445 >
2023-02-22 20:13:52 +00:00
Eric Engestrom
e316416dd0
docs: include explicit setup in instructions
...
The implicit `meson builddir/` is deprecated, and while we have fixed
our scripts, we forgot to update the docs we give our users ^^'
Signed-off-by: Eric Engestrom <eric@engestrom.ch >
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21468 >
2023-02-22 20:07:16 +00:00
Pierre-Eric Pelloux-Prayer
a502f4fc13
radeonsi/video: use specific PIPE_BIND_ value for video buffers
...
Since 13cb41f666 PIPE_BIND_SHARED was used to allocate driver internal
video buffers. These buffers are never shared, but the intent was to
get non-suballocated buffers and SHARED was used as an indirect flag.
This commit switches to PIPE_BIND_CUSTOM which isn't used anywhere else,
and is now translated as "no suballocation".
The main benefit here is that this allows these buffers to set
use_reusable_pool to true reducing the CPU overhead a lot.
For instance, running the following command on my system:
ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi \
-i tears_of_steel_1080p.mov -an -c:v h264_vaapi output.mp4
takes 35 sec with this commit vs 45 sec without.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Reviewed-by: Boyuan Zhang <boyuan.zhang@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21416 >
2023-02-22 18:30:28 +00:00
Chia-I Wu
635d62ba99
mesa: use mesa_log from output_if_debug
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
f18f43338e
mesa: add missing newlines for _mesa_debug/_mesa_log callers
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
40e45eaef0
util/log: add logger_windbg
...
Because output_if_debug has it.
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
8f0a7e848f
util/log: add support for MESA_LOG_FILE
...
It allows logger_file to log to any file.
v2: check "geteuid() == getuid()"
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
7d8d64426b
util/log: add logger_syslog
...
This is useful when the app is a daemon.
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
bbd19527c1
util/log: improve logger_android
...
Avoid __android_log_vprint which can truncate messages. Also add
MESA_LOG=wait to lower the chance of logger_android dropping messages.
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
7a18a1712a
util/log: improve logger_file newline handling
...
Add logger_vasnprintf that will be used by other loggers. For
logger_file, it improves newline handling for
mesa_logd("%s", "hello\n");
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
63864d4dfc
util/log: allow multiple loggers
...
It still logs to logcat on Android and stderr otherwise by default.
MESA_LOG is introduced to override the loggers.
v2: add va_copy
Reviewed-by: Emma Anholt <emma@anholt.net > (v1)
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Chia-I Wu
337d58f6fc
util/log: refactor mesa_log
...
Add logger_file and logger_android.
Reviewed-by: Emma Anholt <emma@anholt.net >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21454 >
2023-02-22 17:55:40 +00:00
Alejandro Piñeiro
dd3b67b974
v3dv: handle ASPECT_MEMORY_PLANE aspect flags when getting plane number
...
As we support VK_EXT_image_drm_format_modifier, we could receive
VK_IMAGE_ASPECT_MEMORY_PLANE_0/1/2_BIT_EXT flags.
Fixes several tests like this:
dEQP-VK.drm_format_modifiers.create_explicit_modifier.*
when using CTS 1.3.5.0
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21463 >
2023-02-22 16:27:43 +00:00
Sebastian Wick
f4ce19063c
loader: do not check the mesa DRI_Mesa version if it was not found
...
Signed-off-by: Sebastian Wick <sebastian.wick@redhat.com >
Fixes: 1026d29344 ("dri: Introduce internal Mesa DRI driver loader extension.")
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21429 >
2023-02-22 15:07:24 +00:00
Karol Herbst
6e666c6303
nir: Skip samplers and textures in lower_explicit_io
...
We have specialized lowering passes dealing with most of that already:
1. gl_nir_lower_samplers_as_deref
2. nir_lower_samplers
3. nir_lower_cl_images
If we need more than that, those passes can deal with following deref
chains as well.
We _might_ need to improve nir_lower_cl_images a bit for more complex
kernels, but CL also doesn't allow indirect images, so we are always able
to optimize the entire deref chain away.
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Karol Herbst
186a22712f
rusticl: allocate printf buffer as staging
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Karol Herbst
3abbeed74f
rusticl: no compute only
...
This might be a good optimization, but we should figure first what drivers
should be able to disable and what not first.
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Karol Herbst
ced9d5d635
rusticl/device: limit CL_DEVICE_MAX_CONSTANT_ARGS
...
At the moment we implement constant memory as normal global memory, but
we still should limit to the actual constant buffer cap once we properly
use UBOs for that.
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Karol Herbst
bbea8761c2
rusticl/device: fix some device limits
...
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Karol Herbst
188c0d7c8f
llvmpipe/ci: increase deqp-runner timeout
...
Some of the OpenCL tests are flaky, because they just take that long.
Builtins can generated really complex code and if we are unlucky they can
timeout.
Proper support for functions would also solve the issue, probably, but for
now increase the deqp-runner timeout so it's less of an annoyence.
Signed-off-by: Karol Herbst <kherbst@redhat.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20161 >
2023-02-22 14:20:21 +00:00
Samuel Pitoiset
7f2775bc8a
radv/ci: cleanup CI lists for dEQP-VK.memory.* tests that timeout
...
These tests usually take more than 30s to complete, so exclude them
completely instead. This should also make runs slightly faster.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21464 >
2023-02-22 13:25:13 +00:00
Eric Engestrom
2809bb8499
broadcom/ci: re-enable egl on wayland
...
Swap them, as suggested by @enunes, to avoid a ton of timeouts in
wayland if the x11 tests ran first.
Needs to be investigated, but at least like this we can get the CI
coverage back.
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Daniel Stone <daniels@collabora.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21453 >
2023-02-22 12:59:04 +00:00
Eric Engestrom
67b2f48645
broadcom/ci: add two known failures
...
The first one in a Pass on both the rpi and the simulator, while the second
one is skipped as NotSupported on both. No idea why it's failing on the
CI, but at least it's consistently failing...
Signed-off-by: Eric Engestrom <eric@igalia.com >
Acked-by: Daniel Stone <daniels@collabora.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21453 >
2023-02-22 12:59:04 +00:00