Emma Anholt
ea5707c52f
turnip: Disable buffer texturing on 422 formats.
...
Fixes:
dEQP-VK.api.info.format_properties.g8b8g8r8_422_unorm
dEQP-VK.api.info.format_properties.b8g8r8g8_422_unorm
and part of:
dEQP-VK.api.info.format_properties.g8_b8_r8_3plane_420_unorm
dEQP-VK.api.info.format_properties.g8_b8r8_2plane_420_unorm
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11562 >
2021-06-24 17:34:06 +00:00
Emma Anholt
6bc88c26b6
ci/turnip: Document create_instance_device_intentional_alloc_fail's fail.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11562 >
2021-06-24 17:34:06 +00:00
Emma Anholt
55000408f9
turnip: Use vk_startup_errorf() in more startup paths.
...
This does the logging for you.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11562 >
2021-06-24 17:34:06 +00:00
Emma Anholt
31f8b70481
turnip: Link more MRs and issues related to our xfails.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11562 >
2021-06-24 17:34:06 +00:00
Emma Anholt
4b44e28526
freedreno/ir3: Report RA failure with mesa_loge().
...
This is a major failure that should never happen (if we had spilling
support), don't hide the log behind DEBUG builds.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11562 >
2021-06-24 17:34:06 +00:00
Erik Faye-Lund
45b7b57a83
iris/ci: disable amly jobs
...
These runners are having stability issues, and is causing a lot of
merge-requests to fail without reason. Let's disable them until the
runners have gotten some stability fixes in place.
See this discussion for details:
https://gitlab.freedesktop.org/mesa/mesa/-/issues/3437#note_971266
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11580 >
2021-06-24 17:13:18 +00:00
Daniel Schürmann
b14bd285f8
aco/ra: handle copies of copies better
...
Instead of adding a second copy, just redirect
the existing copy.
No fossil-db changes.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11571 >
2021-06-24 16:53:10 +00:00
Daniel Schürmann
995e218993
aco/ra: handle copies of definition registers
...
Previously, it could happen that a parallelcopy of
a definition was inserted before the instruction.
Fixes Rage 2 with GFX7.
No fossil-db changes.
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11571 >
2021-06-24 16:53:10 +00:00
Jason Ekstrand
d31dd81292
anv: Claim to be a discrete GPU if has_lmem
...
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Jordan Justen
b6a1063c2e
intel/dev: Set has_local_mem for DG1
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Sagar Ghuge
e505c221fa
anv: Allocate scratch and workaround BO in local memory
...
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Sagar Ghuge
6352371ff6
anv: Allocate BO in appropriate region
...
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Sagar Ghuge
3f8eca7f82
anv: Wrapper around I915_GEM_CREATE_EXT_MEMORY_REGIONS
...
v2 (Jordan Justin):
- add anv_gem_stubs.c impl
v3 (Jason Ekstrand):
- Use the upstream uAPI
- Rework the interface a bit
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Sagar Ghuge
65e8d72bc1
anv: Query memory region info
...
Create additional memory type with DEVICE_LOCAL_BIT if we have local
memory region aviable.
v2 (Jason Ekstrand):
- Don't leak mem_regions if the second ioctl fails
Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Rafael Antognolli
aa3775c8e4
iris: Map with WC on non-LLC platforms.
...
Reworks:
* Jordan: Required rework following
f62724ccac ("iris: Pick a single mmap mode (WB/WC) at BO allocation time")
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Rafael Antognolli
b6a7400dfd
iris/bufmgr: Add flag to allocate from local memory.
...
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Rafael Antognolli
55be94dcab
iris/bufmgr: Add new set of buckets for local memory.
...
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Rafael Antognolli
e60114b2ae
iris/bufmgr: Query memory region info.
...
v2 (Jason Ekstrand):
- Don't leak meminfo if the ioctl fails on the second pass
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Jordan Justen
84069acfd4
iris/bufmgr: Align vma addresses to 64K for local memory
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Jordan Justen
cb6feae0b5
intel/devinfo: Add has_local_mem
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5599 >
2021-06-24 16:14:38 +00:00
Simon Zeni
2fe2eb1911
radv: Implement VK_EXT_acquire_drm_display
...
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca >
Reviewed-by: Simon Ser <contact@emersion.fr >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11014 >
2021-06-24 15:48:38 +00:00
Simon Zeni
f9944899a7
vulkan/wsi: Implement VK_EXT_acquire_drm_display
...
Implements the two functions defined in the extension
VK_EXT_acquire_drm_display, vkAcquireDrmDisplayEXT and vkGetDrmDisplayEXT.
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Reviewed-by: Simon Ser <contact@emersion.fr >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11014 >
2021-06-24 15:48:38 +00:00
Simon Zeni
fdf22aad73
vulkan/wsi: add drm_fd param to wsi_display_get_connector
...
Modifies the signature on `wsi_display_get_connector` to retrieve the
connector of an arbitrary DRM FD instead of the one taken from the
wsi_display.
Signed-off-by: Simon Zeni <simon@bl4ckb0ne.ca >
Reviewed-by: Simon Ser <contact@emersion.fr >
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11014 >
2021-06-24 15:48:38 +00:00
Jason Ekstrand
b8030ab1ea
isl,docs: Add a chapter on AUX state tracking
...
We also update and improve the docs in isl.h which get pulled into this
new chapter.
Acked-by: Luis Strano <luis.strano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11479 >
2021-06-24 13:57:40 +00:00
Jason Ekstrand
94a52bc85c
isl,iris: Move the extra_aux_surf logic into iris
...
This gets rid of the awkward interface for isl_surf_get_ccs_surf where
we passed it two aux surfaces and it was supposed to fill out the second
one based on whether or not the first one already had stuff in it.
Instead, we now pass it three well-labled surfaces: surf,
hiz_or_mcs_surf, and ccs_surf which have obvious meanings. This does
mean that iris has to carry a bit of logic and we have to flip
parameters around in all the callers. But the resulting interface is
much cleaner.
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11479 >
2021-06-24 13:57:40 +00:00
Jason Ekstrand
37f76aab1c
isl: Take a hiz_or_mcs_surf in isl_surf_supports_ccs
...
Whether or not a surface supports CCS on Tigerlake and later is
dependent not only on the main surface but also on the MCS or HiZ
surface, if any. We were doing some of these checks in
isl_get_ccs_surf based on the extra_aux parameter but not as many as we
probably should. In particular, we were really only checking HiZ
conditions and nothing for MCS. It also meant that, in spite of the
symmetry in names, the checks in isl_surf_get_ccs_surf were more
complete than in isl_surf_supports_ccs.
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11479 >
2021-06-24 13:57:40 +00:00
Jason Ekstrand
2d2590a879
isl: Assert some iris invariants in isl_surf_get_ccs_surf
...
The only driver which calls isl_surf_get_ccs_surf with extra_aux != NULL
is iris and it always calls it with two aux surfaces and never calls it
for CCS twice. We can turn those checks into asserts.
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11479 >
2021-06-24 13:57:40 +00:00
Vinson Lee
6fe82e6c1e
asahi: Fix macOS macro.
...
Fixes: 26b19bda30 ("asahi: Add device abstraction")
Fixes: 55c0956fd0 ("asahi: Add (clean room) IOKit uABI header")
Signed-off-by: Vinson Lee <vlee@freedesktop.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11569 >
2021-06-24 13:49:40 +00:00
Erik Faye-Lund
9aff548ff4
libgl-gdi: add missing include
...
Without this, I get the following error if I try to compile Zink without
any other drivers:
src/gallium/targets/libgl-gdi/libgl_gdi.c(210): error C2037: left of
'flush_frontbuffer' specifies undefined struct/union 'pipe_screen'
Fixes: fdfe4a4d30 ("libgl-gdi: add zink support")
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11536 >
2021-06-24 09:30:20 +00:00
Erik Faye-Lund
fa784acbdf
zink: remove some needless moltenvk details
...
This removes a macro that we don't need, and removes a comment about a
detail that we don't care about in that location.
Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:47:00 +02:00
Erik Faye-Lund
ccb9f8670e
zink: do not store moltenvk functions in screen
...
These functions are only used once anyway, no need to store them and
make the rest of Zink care.
Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:46:55 +02:00
Erik Faye-Lund
95cbb560cf
zink: remove unused moltenvk functions
...
These functions were added, but never used. Let's get rid of them.
Fixes: c2cb2dd3bc ("zink: Added support for MacOS MoltenVK APIs.")
Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:46:52 +02:00
Erik Faye-Lund
7b220f8694
zink: unbreak moltenvk code
...
These functions don't exist in the Khronos XML, so we don't generate
dispatch-table entries for them. So let's not try to call them in that
way.
Fixes: 5574868103 ("zink: use the dispatch tables")
Acked-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Acked-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:46:31 +02:00
Erik Faye-Lund
e979ecbd45
zink: remove unused function-pointers
...
We also forgot to remove these when we stoped using them, more stuff to
delete, yeah!
Fixes: 5574868103 ("zink: use the dispatch tables")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:46:13 +02:00
Erik Faye-Lund
efa863990a
zink: drop unused macros
...
We stopped using these without removing them, let's tidy that bit up.
Fixes: 5574868103 ("zink: use the dispatch tables")
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11554 >
2021-06-24 10:45:18 +02:00
Dave Airlie
d2114bf413
crocus: fix another printf specifier.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11570 >
2021-06-24 07:10:49 +00:00
Dave Airlie
78c979dc93
crocus/gfx6: always be dirtying gs attachments for xfb
...
This fixes hangs seen with xfb and the deqp test
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Dave Airlie
7399d6028f
crocus: Avoid replacing backing storage for buffers with no contents
...
Ported 97e9de1795 from iris
We might get asked to pitch the storage on a buffer that already has
no meaningful contents. In this case, the existing buffer is as good
as a new one.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Dave Airlie
0fa4b64f6c
crocus: dirty blend state more often.
...
The blend state depends on wm_prog_data dual_src and it also
depends on the cbuf formats in can_emit_logic_op.
Dirty it in the correct places.
Fixes:
dEQP-GLES3.functional.fbo.invalidate*
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Dave Airlie
a74c16e5f8
crocus/gfx6: fix sampler view first level.
...
The gfx6 state needs to dirty sampler state so that BaseMipLevel
gets updated properly.
Fixes:
dEQP-GLES3.functional.texture.mipmap.cube.base_level.*
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Dave Airlie
0acd202858
intel/genxml: fix gfx6 GS SVB_INDEX encoding
...
This seems to match what the docs + 965 traces say
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Dave Airlie
c282a082be
crocus/query: poll the syncobj in the no wait situation
...
In the no wait, poll the syncobj and bail if it's hasn't signalled.
This fixes a bunch of deqp xfb tests on sandybridge
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11567 >
2021-06-24 06:50:49 +00:00
Adam Jackson
9ca6abd424
vl/dri3: Don't leak regions on the X server
...
I can't tell from a quick read whether this clip region is actually just
the bounding box so could be skipped entirely. But the old code never
destroyed it, which means we'd leak a couple hundred bytes on the X
server side for every SwapBuffers until the client dies of XID
exhaustion, which is somewhere north of 2GB for typical systems so you
may or may not just run out of memory first.
Create the region at swap time and stash it in the drawable state.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11461 >
2021-06-24 03:18:06 +00:00
Adam Jackson
7e9424d91b
loader/dri3: Don't churn through xfixes regions in SwapBuffers
...
Regions are not expensive objects on the server side, it's very slightly
cheaper to update an existing one than to create a new one, and we can
garbage collect them when the drawable is destroyed. Worse, XID reuse
bugs exist, so the more we can do to not churn through XIDs the better.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11461 >
2021-06-24 03:18:06 +00:00
Adam Jackson
34e4622983
loader/dri3: Properly initialize the XFIXES extension
...
The server starts off assuming the only XFIXES request the client might
known is FixesQueryVersion, and based on the version number the client
supplies it unlocks additional requests. If you forget to do this then
xcb_xfixes_create_region will throw BadRequest and you will be very
confused. libXfixes would hide this for you in extension setup but xcb
is not so forgiving.
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11461 >
2021-06-24 03:18:06 +00:00
Marek Olšák
888b7ba338
radeonsi: optimize set_inlinable_constants when they don't change
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509 >
2021-06-23 22:37:34 -04:00
Marek Olšák
86355b5984
ac/gpu_info: adjust the condition for use_late_alloc
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509 >
2021-06-23 22:37:32 -04:00
Marek Olšák
ff42fd1fdf
radeonsi: don't use NGG culling on 1 RB chips
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509 >
2021-06-23 22:37:31 -04:00
Marek Olšák
f7afcc3d11
radeonsi: remove incorrect comment about hangs in gfx10_ngg_gs_emit_epilogue
...
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509 >
2021-06-23 22:37:29 -04:00
Marek Olšák
593f3b3a5a
radeonsi: if shader culling culls all vertices, cull the primitive exports too
...
This was overlooked. It benefits triangle strips the most due to
GS fast launch.
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509 >
2021-06-23 22:37:27 -04:00