AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
167,783 Commits 1 Branch 0 Tags
dccf6f569b6ef63ec20600d844638e561270d6df
Commit Graph

167783 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Alyssa Rosenzweig dccf6f569b agx/lower_address: Break on match 
Once we've matched a summand, commit to it. This avoids needlessly checking the
second source if the first matched, and removes some indentation/funny control
flow.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21643>
 2023-03-07 02:58:35 +00:00
Sergi Blanch Torne 36f6eb88cb Revert "ci: disable Collabora's LAVA lab for maintance" 
This reverts commit https://gitlab.freedesktop.org/mesa/mesa/-/commit/6be7469df1e12bd57c697ff7e34bbda8286d67a2

Signed-off-by: Sergi Blanch Torne <sergi.blanch.torne@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21356>
 2023-03-07 02:23:00 +00:00
Mike Blumenkrantz b5fc941f2f zink: always set batch usage for descriptors after barrier 
this otherwise breaks unordered promotion calc

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz afb56bad1c zink: set dynamic pcp for unordered cmdbuf 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz c5f901dbc6 zink: bind descriptor buffers to unordered cmdbuf 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz 20c9cfb30f zink: always set color writes on the unordered cmdbuf 
this state has to be set, so ensure it is

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz 8e3ee9aad6 zink: explicitly flush src clears when u_blittering 
this otherwise relies on set_framebuffer_state flushing them,
which may or may not be accurate/desired

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz 1aa62912b7 zink: don't unset existing access when adding resource binds 
this breaks barrier calcs, but it was fine since there was a pre-barrier

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz a0f3d171f6 zink: eliminate pre barrier for adding resource binds 
this will automatically be handled by the copies below

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz d133f95084 zink: check for layout updates when unbinding samplerviews 
not sure if it's a bug, but it should be consistent with shader image
unbinding, so here it is

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz a4b1ae1f03 zink: propagate valid_buffer_range when replacing buffer storage 
this is otherwise unreliable

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz 7145ccfa05 zink: fix descriptor update flagging on null ssbo set 
this could unset the update flag if the last ssbo was null, which would
be a bug if it could ever be triggered

found by inspection

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mike Blumenkrantz e0dfe058c4 zink: only add deferred barrier on fb unbind when layout needs to change 
this otherwise may have been a surface that was never drawn to or
already had its layout corrected, in which case a deferred barrier
is not only unnecessary, it might be broken

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21739>
 2023-03-07 01:57:41 +00:00
Mark Janes bc04e2daca intel/fs: use generated helpers for Wa_1209978020 / Wa_18012201914 
Wa_1209978020 is a clone of Wa_18012201914.  Update references to
refer to the originating bug, and use generated helpers to ensure it
is applied to future platforms as needed.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21741>
 2023-03-07 01:41:53 +00:00
Caio Oliveira c92d589597 intel/compiler: Drop non-scoped barrier handling 
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Alyssa Rosenzweig 02eef8ca98 gallivm: Drop non-scoped barrier handling 
Now unreachable.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Alyssa Rosenzweig c8147e69d3 ir3: Drop non-scoped barrier handling 
Now unreachable.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Alyssa Rosenzweig fc93e8e537 pan/mdg: Drop control_barrier handling 
Now unreachable.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Alyssa Rosenzweig cb0f4b8146 pan/bi: Drop control_barrier handling 
Now unreachable.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Alyssa Rosenzweig f47ea3f992 glsl/nir: Use scoped_barrier for control barrier 
Rather than control_barrier. This avoids the need to handle control_barrier at
all for backends that set use_scoped_barrier. This effectively matches what
spirv_to_nir emits, so Vulkan-capable compilers should be ok.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Caio Oliveira 07de034791 intel/compiler: Drop brw_nir_lower_scoped_barriers 
Now that we handle scoped barriers with execution scope during
NIR -> Backend IR translation, this lowering is not needed anymore.

Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Caio Oliveira dfc34b1a65 intel/vec4: Handle scoped barriers with execution scope 
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Caio Oliveira db0a09c9e2 intel/fs: Handle scoped barriers with execution scope 
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21634>
 2023-03-07 00:41:13 +00:00
Yiwei Zhang ae6eb3229e venus: revert back the warn order 
This reverts
- commit 4ae4e4362c
- commit f54aa49c14

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21542>
 2023-03-07 00:25:07 +00:00
Yiwei Zhang 28bdf8db18 venus: vn_relax to abort on ring fatal status upon warn order 
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21542>
 2023-03-07 00:25:07 +00:00
Yiwei Zhang adb51eeba5 venus: propagate vn_ring to vn_relax 
This is to prepare for vn_relax to check ring status as well as pinging
renderer.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21542>
 2023-03-07 00:25:07 +00:00
Yiwei Zhang 15a55198ec venus: abort ring submit when ring is in fatal status 
This change also migrates to use the protocol defined status enums.

Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21542>
 2023-03-07 00:25:07 +00:00
Yiwei Zhang 0b45893823 venus: sync to latest protocol for ring status enum 
Signed-off-by: Yiwei Zhang <zzyiwei@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21542>
 2023-03-07 00:25:07 +00:00
Mark Janes b96019f82b intel/fs: use generated workaround helpers for Wa_14010017096 
This workaround does not apply beyond gen 12.0.

Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21746>
 2023-03-07 00:10:33 +00:00
Mark Collins 66d2ae0386 meson: forcefully disable libdrm when host doesn't have it 
Signed-off-by: Mark Collins <mark@igalia.com>
Reviewed-by: Eric Engestrom <eric@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21724>
 2023-03-06 22:40:55 +00:00
Alyssa Rosenzweig 952bd63d6d nir/opt_barrier: Generalize to control barriers 
For GLSL, we want to optimize code like

   memoryBarrierBuffer();
   controlBarrier();

into a single scoped_barrier intrinsic for the backend to consume. Now that
backends can get scoped_barriers everywhere, what's left is enabling backends to
combine these barriers together. We already have an Intel-specific pass for
combining memory barriers; it just needs a teensy bit of generalization to allow
combining all sorts of barriers together.

This avoids code quality regression on Asahi when switching to purely scoped
barriers. It's probably useful for other backends too.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21661>
 2023-03-06 22:09:27 +00:00
Faith Ekstrand 83fd7a5ed1 intel: Use nir_lower_tex_options::lower_index_to_offset 
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21546>
 2023-03-06 21:38:32 +00:00
Alyssa Rosenzweig 4b6d98a40c ir3: Use lower_index_to_offset 
Instead of doing the add ourselves.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21546>
 2023-03-06 21:38:32 +00:00
Alyssa Rosenzweig 510d3ab93d pan/bi: Use lower_index_to_offset 
Instead of doing the add ourselves.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Reviewed-by: Emma Anholt <emma@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21546>
 2023-03-06 21:38:32 +00:00
Alyssa Rosenzweig 282aeb9b9c nir/lower_tex: Add lower_index_to_offset 
Some backends can handle a constant texture index or a dynamic texture index but
not a constant texture index plus a dynamic texture offset. Add a nir_lower_tex
option to lower to one of these options.

v2: Use more straightforward code proposed by Faith.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Emma Anholt <emma@anholt.net> [v1]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21546>
 2023-03-06 21:38:32 +00:00
Sam Edwards 9de997bde6 nouveau: Fix null dereference in nouveau_pushbuf_destroy 
This may happen if the Nouveau device fails to initialize before
the pushbuf is set up; the abort logic will call this either way.

Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21611>
 2023-03-06 20:25:10 +00:00
Daniel Stone 34d45df8ff ci/fdno: Only run full tests on a limited subset of machines 
Though not many people run full test runs, it occupies 2/7 a630 slots
for nearly 2 hours. If more than one person does this at a time, it can
be an effective DoS and make merges time out.

Limit full runs to a subset of the runners, such that at least some of
them will always be available for us.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21737>
 2023-03-06 19:56:39 +00:00
Rob Clark 399012a911 freedreno/common: Replace or_mask() with BitsetEnum<T> 
Use template and operator overloading to make dealing with bitmask enums
shared between C and C++ easier.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21535>
 2023-03-06 19:27:19 +00:00
Eric Engestrom 30d469215b v3d/ci: add dEQP-GLES3.functional.texture.specification.teximage2d_pbo.*_cube flakes 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21735>
 2023-03-06 19:02:37 +00:00
Mike Blumenkrantz 62f1a8a3a6 zink: unbind fb on context destroy 
this ensures that batch refs are added for fb surfaces on unbind, which
prevents stale batch tracking from persisting on resources
after the context is destroyed

fixes:
*EGL.functional.render.multi_context*

cc: mesa-stable

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21727>
 2023-03-06 18:47:41 +00:00
Guilherme Gallo 7600e2cca2 ci: Handle carriage return characters in LAVA logs 
This commit updates LogFollower class to handle carriage return
characters in LAVA logs. LAVA treats carriage return characters as a
line break, so each carriage return in an output console is mapped to a
console line in LAVA.

The updated LogFollower class now merges lines that end with a carriage
return character into a single line, making the Gitlab sections work
correctly. In addition, the `remove_trailing_whitespace` method has been
updated to remove trailing `\r\n` characters from log lines.

The `test_lava_log_merge_carriage_return_lines` test function has also
been updated to test for carriage returns at the end of the previous
line.

Closes: #8242

Signed-off-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21614>
 2023-03-06 17:17:32 +00:00
Italo Nicola 3174cfcaf2 hud: add GALLIUM_HUD_OPACITY envvar 
GALLIUM_HUD_OPACITY can be used with a % value from 0 to 100, to specify
the opacity of the gallium hud background.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Tested-by: Chris Healy <healych@amazon.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20339>
 2023-03-06 16:50:27 +00:00
Italo Nicola 7ace1bab73 hud: use defines for default scale/rotation/visibility values 
Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20339>
 2023-03-06 16:50:27 +00:00
Ruijing Dong 0f3370eede raseonsi/vcn: fix a h264 decoding issue 
reason:
   some h264 streams have some strange pictures, from
   vaapi input these pictures don't have a reference frame,
   however, they are not intra only pictures, in MB layer
   these pictures are looking for some references, if they
   cannot find it. It could cause PF.

   when reference pictures exist, it will need to set used_for
   reference_flags, therefore if that is set, however the
   number of reference frames is zero, which is odd, it
   should be avoided.

solution:
   In the above case,  to scan the ref list so that it will
   make at least one reference available to avoid crash, since
   this is not accurate enough, it could cause some artifacts.
   And in that case, it will need to be checked individually
   for another solution.

closes: https://gitlab.freedesktop.org/drm/amd/-/issues/1462
closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/8401
Cc: mesa-stable

Tested-by: llyyr <llyyr.public@gmail.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Signed-off-by: Ruijing Dong <ruijing.dong@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21732>
 2023-03-06 16:38:19 +00:00
Mike Blumenkrantz 340f2d1a25 zink: add frame trace markers on the queue 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21655>
 2023-03-06 16:23:21 +00:00
Sonny Jiang bb796f70a1 radeonsi: Add NV12 support for AV1 
8bit av1 decoding cannot use NV12 output, which is caused by missing NV12 RT format.
It's a regression caused by commit [0504a3b0].
Fixes: 0504a3b0  ("radeonsi: correctly declare YUV420_10 RT Format support for AV1")
Cc: mesa-stable

Signed-off-by: Sonny Jiang <sonny.jiang@amd.com>
Reviewed-by: David Wu <David.Wu3@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21697>
 2023-03-06 16:10:40 +00:00
Samuel Pitoiset 0ed28d2715 wsi: move an assertion in wsi_xxx_surface_get_capabilities2() 
Hit this with vulkaninfo on X11, probably a vulkaninfo bug. Though
moving the assertion doesn't hurt.

Fixes: be0dcbdfa2 ("wsi/x11: Implement EXT_swapchain_maintenance1.")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Hans-Kristian Arntzen <post@arntzen-software.no>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21722>
 2023-03-06 14:40:02 +00:00
Mike Blumenkrantz c3cc8455d4 zink: when skipping a TRANSFER_DST image barrier, set access tracking 
this otherwise breaks subsequent barriers if the first barrier of the batch
is a TRANSFER_DST on an image that can skip such a barrier

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21583>
 2023-03-06 14:22:01 +00:00
Mike Blumenkrantz e650ff4ea0 zink: remove debug markers for u_blitter ops 
these don't actually work; it creates the marker for the op, but
then the "end" of the marker is effectively determined to be the end
of the cmdbuf

instead, detect whether a draw is from u_blitter and add a marker there

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21583>
 2023-03-06 14:22:01 +00:00
Mike Blumenkrantz 271ebdd735 zink: pass cmdbuf to debug marker begin 
this is otherwise broken with cmdbuf reordering

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21583>
 2023-03-06 14:22:01 +00:00